Update sqlx #2617
Merged
Update sqlx #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
requested review from
philippecamacho,
ImJeremyHe and
sveitser
as code owners
jparr721
approved these changes
Feb 13, 2025
try w/ bundled on updated sqlx
imabdulbasit
approved these changes
Feb 14, 2025
tbro
added a commit
that referenced
this pull request
Feb 14, 2025
Updating sqlx to `0.8.3` appears to resolve. Excessive memory usage when compiling bundled sqlite. It was originally planned to add `sqlite-unbundled` as well to use native/system sqlite, but apparently excessive memory usage disappears w/ out that change. And it may be disruptive as our deployments currently rely on the bundled sqlite. As a followup, we can consider adding our own `sqlite-unbundled` feature to easily avoid compiling sqlite where we know there is one available in testing. --------- Co-authored-by: tbro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OOM while compiling squencer-sqlite