Conditionally compile versions #2559
Open
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tests in their current state we will probably need to enable 2
versions most of the time. I'm not sure about configuration through
the environment, but this leads me to believe we can pass the proper
configuration to `rustc`.
RUSTFLAGS="--cfg feature=\"fee\"" cargo +nightly -Z unstable-options rustc --print cfg
Note that `--print` option of `cargo rustc` is only available on nightly.
Closes #2558
tbro
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
This reverts commit 77e426d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2558
With this change you can pass
--feature feeto only compile fee version. The idea is to reduce compile time by targeting only those features you are currently working on / testing. For CI in its current state we will probably need to enable 2 versions most of the time.I'm not sure about configuration through the environment, but the following leads me to believe we can pass the proper configuration to
rustc:Note that
--printoption ofcargo rustcis only available on nightly.