[Monorepo] Final HotShot Merge #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix BuilderDataSource for marketplace builder
* all tests passing still, wired up secondary event source * revert * working * cleanup, clippy * working test * propagate event streams and remove propser * fix dependency tasks and invalid key * comments * reduce complexity of spawning behavior
* Add test for verify_share return type * Remove patch and ignore test * Fix typo * commit other mod.rs file * just fmt * Remove jellyfish patch from cargo toml * PR comments * Clippy fixes
* add health check task * add a periodic heart beat for main tasks * rebase and format * cleanup * minor cleanup * change task id to include task name and a number * cleanup * cleanup async-std and tokio scopes in loops * cleanup * remove uneeded helper functions to avoid duplication * minor cleanup * pin fused receive stream on task startup * fix tests * address comments
* implement message signing * fix comments * fix compiler error on dep tasks, fix test * fix name * continuously wait for the proposal
* add support for DA broadcast * working test * tmp * add support for fused message type, verify failure condition and fix it * rename
…3621) * first pass * lints * try to pull stake table key (#3622) * misc cleanup * allow disable verification * finish all validation and bug fixes * remove old log * vec->hashset * misc feedback fixes * remove check --------- Co-authored-by: rob-maron <[email protected]>
* clean up Libp2p * remove bootstrap from tests * small updates * Not sure how this was working before * pick port * lint * Update crates/libp2p-networking/src/network/node.rs Co-authored-by: Artemii Gerasimovich <[email protected]> * Update crates/libp2p-networking/src/network/node.rs Co-authored-by: Artemii Gerasimovich <[email protected]> * review changes * move all configuration up to `from_config` * `bootstrap_addrs` -> `node_addrs` * fix examples * remove `libp2p` config from config file --------- Co-authored-by: Artemii Gerasimovich <[email protected]>
* fix log * make entry true again
Bumps the all group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [async-trait](https://github.com/dtolnay/async-trait) | `0.1.81` | `0.1.82` | | [tokio](https://github.com/tokio-rs/tokio) | `1.39.3` | `1.40.0` | | [delegate](https://github.com/kobzol/rust-delegate) | `0.12.0` | `0.13.0` | | [derive_builder](https://github.com/colin-kiegel/rust-derive-builder) | `0.20.0` | `0.20.1` | | [syn](https://github.com/dtolnay/syn) | `2.0.76` | `2.0.77` | Updates `async-trait` from 0.1.81 to 0.1.82 - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](dtolnay/async-trait@0.1.81...0.1.82) Updates `tokio` from 1.39.3 to 1.40.0 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.39.3...tokio-1.40.0) Updates `delegate` from 0.12.0 to 0.13.0 - [Changelog](https://github.com/Kobzol/rust-delegate/blob/main/CHANGELOG.md) - [Commits](Kobzol/rust-delegate@v0.12.0...v0.13.0) Updates `derive_builder` from 0.20.0 to 0.20.1 - [Release notes](https://github.com/colin-kiegel/rust-derive-builder/releases) - [Commits](colin-kiegel/rust-derive-builder@v0.20.0...v0.20.1) Updates `syn` from 2.0.76 to 2.0.77 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.76...2.0.77) --- updated-dependencies: - dependency-name: async-trait dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: delegate dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: derive_builder dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…77)" (#3629) This reverts commit 30bcd4d801a8e8066f0df031c4c31c9df14b354b.
* Add a test for dishonest voting - not finished * Finish up the test for dishonest voting * Create a helper function to remove code duplication * Use new helper function in all applicable places * Update crates/task-impls/src/network.rs Co-authored-by: lukeiannucci <[email protected]> * Simplify if else and adjust clippy --------- Co-authored-by: lukeiannucci <[email protected]>
* refactor byzantine code, start view lag * test cleanup * cleanup * remove node id * cleanup * run clippy * run formatter * address comments * cleanup * restore cargo * speed up tests * fix check to go into lookback logic * remove view as we see * add guarding * remove heartbeat event * rebase and fix merge conflicts --------- Co-authored-by: Luke Iannucci <[email protected]>
* bump version to 0.5.73 * update cargo.lock * turn off enable_registration_verification * restore enable_registration_verification to true * latest main * clippy * clippy
…(#3648) * Add second view param to init, spin nodes in tests up from view 0 * add last actioned views to consensus * check view before doing action * fmt and lint * log error when trying to double propose/vote * fix for DA votes * still update the da vote view * restart with actioned view from storage * lint * Allow access to consensus from byz tests, reset actions in byz behavior * lint
* Add struct StakeTableState. * Remove fields from the GenericLightClientState * Remove no longer used fields from the generalPublicInput that have been removed from the light client state --------- Co-authored-by: Alysia Huggins <[email protected]> Co-authored-by: Alex Xiong <[email protected]>
* refactor memberships * fmt * improve API * Make sure each node has above-zero stake * remove non-staked node support * PR comments * fix `random/fixed` leader election to use `eligible_leaders`
* coordination attack * cleanup * cleanup and dont send timeout for Byzantine replica * refactor how we send votes, check a shared hashset * cleanup
* actually restart all nodes in restart tests * saturating sub * lint
We were sometimes decoding as the wrong type. This adds a function that decodes to the old VID type if deserializing the new type fails. I think we want a better solution but this does at least fix the tests for me.
rob-maron
pushed a commit
that referenced
this pull request
Feb 7, 2025
Bumps [clap](https://github.com/clap-rs/clap) from 4.4.18 to 4.5.0. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.4.18...clap_complete-v4.5.0) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…sso-sequencer into jp/the-final-merge
…sso-sequencer into jp/the-final-merge
…sso-sequencer into jp/the-final-merge
…sso-sequencer into jp/the-final-merge
* nextest: partition tests * nextest: remove parallelism - Use hash partition for more determinism
* Speed up test CI workflow Remove restriction to run tests serially. The slowest of the test partitions now takes about 8 minutes on the CI This seems to work pretty well locally except for tests_4::test_marketplace::test_marketplace_fallback_builder_down::testtypes_::memoryimpl_::test_marketplace_fallback_builder_down^ which I can't seem to get to pass at all, even if it's running in isolation. * more retries for flaky tests * CI: run test_with_builder_failure in isolation
rob-maron
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to merge HotShot to avoid a huge diff when we finally add it. This will be the PR which first fixes all the bugs.