Fix EpochCommittees returning stake tables out of order
#2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-es
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
imabdulbasit
approved these changes
Jan 30, 2025
types/src/v0/impls/stake_table.rs
Outdated
| @@ -126,10 +126,16 @@ struct Committee { | |||
| /// leader but without voting rights. | |||
| eligible_leaders: Vec<StakeTableEntry<PubKey>>, | |||
|
|
|||
| /// TODO: add comment | |||
| /// Stake table | |||
There was a problem hiding this comment.
maybe add a comment explaining why we need these vectors
jbearer
reviewed
Jan 30, 2025
types/src/v0/impls/stake_table.rs
Outdated
| indexed_stake_table: BTreeMap<PubKey, StakeTableEntry<PubKey>>, | ||
|
|
||
| /// TODO: comment | ||
| /// DA members indexed by public key, for efficient lookup. | ||
| indexed_da_members: BTreeMap<PubKey, StakeTableEntry<PubKey>>, |
There was a problem hiding this comment.
Nit: maybe make the value here usize index into stake_table and da_members, so we only have a single source of truth for the actual contents of the stake table entry?
There was a problem hiding this comment.
Also consider BTreeMap -> HashMap so it is more clear that nothing is actually ordered by keys?
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
(cherry picked from commit 0f75108)
|
Successfully created backport PR for |
ss-es
added a commit
that referenced
this pull request
Jan 30, 2025
…les out of order (#2515) Fix `EpochCommittees` returning stake tables out of order (#2514) (cherry picked from commit 0f75108) Co-authored-by: ss-es <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes an issue where
EpochCommitteeswas previously returning stake tables out of order. We now store (and prefer) the vector passed toEpochCommittees::new_stakewithout modification, and only retain aBTreeMapfor lookup.This PR does not:
Key places to review: