Clean up some noisy logging #2459
Merged
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
tbro and
imabdulbasit
as code owners
rob-maron
approved these changes
Jan 16, 2025
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Don't log warning when a requested object is simply not found (cherry picked from commit 9e69a39)
jbearer
added a commit
that referenced
this pull request
Jan 16, 2025
Clean up some noisy logging (#2459) Don't log warning when a requested object is simply not found (cherry picked from commit 9e69a39) Co-authored-by: Jeb Bearer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't log warning when a requested object is simply not found; it is considered normal for nodes to sometimes be missing this data. We should only warn when there is some other error when looking up the data (connection closed ,etc)