Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Thirft API version to 0.21.0 #4425

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gamesh411
Copy link
Collaborator

The current version of Thrift is quite old, and the generated Python stubs are triggering deprecation warnings in modern Python versions (I tested it with Python 3.12). Additionally, the official Docker image used for compiling Thrift definition files is outdated. To address this, I have introduced a customization point in the build system, making it easier to configure when building the CodeChecker API packages.

@gamesh411 gamesh411 marked this pull request as ready for review January 20, 2025 09:54
THRIFT_DOCKER_IMAGE ?= thrift
# The current default for THRIFT_VERSION is latest version of the currently
# unmaintained official thrift image on dockerhub
# This is the version of the Docker image, and currently we are operating on
Copy link
Collaborator Author

@gamesh411 gamesh411 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, this statement about version matching is just too speculative and refer to a bigger context (therefore misleading), so I remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant