Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mode where CTU files are retained #4413

Closed
wants to merge 1 commit into from

Conversation

tomrittervg
Copy link

For debugging purposes I wanted to retain the CTU files. In case this sounds useful, I'll throw the patch here.

@bruntib
Copy link
Contributor

bruntib commented Jan 22, 2025

Hi,

Thanks for the patch! However, as a rule of thumb, we would like to go in the direction of not introducing further flags unless it's unavoidable otherwise.

CodeChecker analyze command has --ctu-collect and --ctu-analyze flags. The first one is producing the CTU files and the second one is using them for analysis. The --ctu flag is almost equivalent with providing both flags. When we need to debug the generated CTU files, then we run --ctu-collect only. Would you think, this is a good methodology for testing CTU?

@tomrittervg
Copy link
Author

Personally that won't work for me because I need to run the entire thing overnight, --ctu-analyze will delete the files when its done, and my ctu-dir is >400GB so I don't want to copy the files just to move them back after they're deleted; but I understand it's a fringe case so I'm not upset if you don't want to take the patch.

@bruntib
Copy link
Contributor

bruntib commented Jan 23, 2025

I understand the motivation and I agree with having a solution for debugging reasons. I'm just suggesting an alternative solution to execute the analysis in two phases. I mean if you execute CodeChecker analyze with --ctu-collect and --ctu-analyze separately, then the analysis is the same and ctu-dir is not removed.

@tomrittervg
Copy link
Author

I understand the motivation and I agree with having a solution for debugging reasons. I'm just suggesting an alternative solution to execute the analysis in two phases. I mean if you execute CodeChecker analyze with --ctu-collect and --ctu-analyze separately, then the analysis is the same and ctu-dir is not removed.

Oh, I misunderstood or mis-remembered the code then, I thought it was still removed after ctu-analyze even if it was two phases, but that doesn't seem to be the case.

Thanks, I will migrate to that pattern at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants