Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(root): attempt fix for commits not associated to branch #332

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

cloudratha
Copy link
Collaborator

@cloudratha cloudratha commented Oct 31, 2024

📲 What

Commits raised in CI do not belong to any branches.
Not quite sure why, but believe it to be a combination of not specifying the ref in checkout and branch protection.
Explicitly calling the ref, I hope to see tags associated to commits that belong to a branch.

🤔 Why

When we do a release we gather tags from commits. It will not observe commits that do not belong to any branches, resulting in the incorrect semver version produced which causes catastrophic failure when trying to push the same version up to npm.

image

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

Copy link

nx-cloud bot commented Oct 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d82c749. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@cloudratha cloudratha merged commit b448795 into main Nov 1, 2024
11 checks passed
@cloudratha cloudratha deleted the ci/commits-to-branch branch November 1, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants