change to single process for bootstrap_stderr #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhuyuhua-v <[email protected]>
zhuyuhua-v
requested review from
baberabb and
lintangsutawika
as code owners
|
|
|
@baberabb @lintangsutawika Could you please take a look at this issue #2581 and see if there might be a better solution? I’ve submitted this PR to address it, and I’d appreciate it if you could review it to check whether it’s suitable. |
|
Hi! I've been meaning to look into this more. I don't think removing the multiprocessing is appropriate as mp still does work in windows. Need to debug this a bit more. |
Thank you for your support! I really appreciate your efforts in looking into this further and look forward to any findings you find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2581, replace the origin multi-process bootstrap_stderr with single process to avoid repeated running scripts during perplexity task execution on Windows