Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the format of mgsm zh and ja. #2587

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Fix the format of mgsm zh and ja. #2587

merged 5 commits into from
Jan 7, 2025

Conversation

timturing
Copy link
Contributor

This is discussed in #2578 .

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2024

CLA assistant check
All committers have signed the CLA.

@baberabb
Copy link
Contributor

LGTM! could you sign the CLA, if you're willing. We can't merge without without that.

@timturing
Copy link
Contributor Author

Thanks for the review and sorry for missing the CLA earlier! I've signed it now. Please let me know if there's anything else needed.

@baberabb
Copy link
Contributor

baberabb commented Jan 7, 2025

Looks great! closes #2578

@baberabb
Copy link
Contributor

baberabb commented Jan 7, 2025

@timturing one last thing. i cant seem to edit the PR. Could you increment the versions in direct_yaml, native_cot/cot_yaml and en_cot/cot_yaml and add a change-log like below to the readme

# changelog
- (en_cot, direct) ver 3; (native_cot) ver 4: issue #2578; PR #2587
  - fix fewshot format: Changed inconsistent usage of ':' (ASCII) and ':' (Chinese) to use ':' consistently.

@baberabb baberabb merged commit bb098f1 into EleutherAI:main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants