Migrate to ruff #423
Merged
Migrate to ruff #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As #360 shows, black and reorder-python-imports conflict on how they format imports. Switch over to `ruff` + its builtin import sorter (isort).
nicoddemus
requested review from
prusse-martin,
cauebs,
ro-oliveira95 and
BeneBr
nicoddemus
commented
Feb 4, 2025
nicoddemus
force-pushed
the
migrate-to-ruff
branch
from
2b8e3b0 to
fbf1ab2
Compare
|
| distance = Quantity( | ||
| value=1, unit="m", caption="Distance" | ||
| ) | ||
| distance = Quantity(value=1, unit="m", caption="Distance") |
There was a problem hiding this comment.
I just ask myself why did it reformat the string.
There was a problem hiding this comment.
It also formats code in docstrings IIRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #360 shows, black and reorder-python-imports conflict on how they format imports.
Switch over to
ruff+ its builtin import sorter (isort).