Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for env_batch.zip #4747

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix for env_batch.zip #4747

merged 1 commit into from
Feb 10, 2025

Conversation

jgfouca
Copy link
Contributor

@jgfouca jgfouca commented Feb 6, 2025

Need to watch out for scan_children finding more children than intended when node1 has no attributes

Test suite: ./scripts_regression_tests.py test_unit_xml_env_batch.TestXMLEnvBatch
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Need to watch out for scan_children finding more children than
intended when node1 has no attributes
@jgfouca jgfouca requested a review from jasonb5 February 6, 2025 20:17
@jgfouca jgfouca self-assigned this Feb 6, 2025
Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfouca jgfouca merged commit 3d87cf1 into master Feb 10, 2025
7 checks passed
@jgfouca jgfouca deleted the jgfouca/fix_env_batch_zip branch February 10, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants