Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_059: issue 1212 bug fix (cloud frac ice+liquid) #1230

Conversation

PeterHjortLauritzen
Copy link
Collaborator

@PeterHjortLauritzen PeterHjortLauritzen commented Jan 23, 2025

Bug fix provided by @adamrher to fix issue 1212

closes #1212

Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the "auto closing feature" needs to have a variation of the word fixes, resolves or closes followed immediately by the issue number. I've modified your description to get the auto-closer to work.

See: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue


icecldf(:ncol,:pver) = ast(:ncol,:pver)
call pbuf_get_field(pbuf, aist_idx, aist, start=(/1,1,itim_old/), kount=(/pcols,pver,1/))
!icecldf(:ncol,:pver) = ast(:ncol,:pver)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we go ahead and remove this commented out line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@cacraigucar cacraigucar self-assigned this Jan 23, 2025
@cacraigucar cacraigucar changed the title issue 1212 bug fix (cloud frac ice+liquid) cam6_4_059: issue 1212 bug fix (cloud frac ice+liquid) Jan 23, 2025
Merge pull request ESCOMP#1231 from PeterHjortLauritzen/issue1222_1208_clubb_bugfix_and_namelist_chg
@cacraigucar cacraigucar merged commit b3ef374 into ESCOMP:cam_development Feb 4, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 13, 2025
Merge pull request ESCOMP#1230 from PeterHjortLauritzen/issue1212_nucleate_ice_cam_bugfix

cam6_4_059: issue 1212 bug fix (cloud frac ice+liquid)

ESCOMP commit: b3ef374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants