-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for event entities #644
base: main
Are you sure you want to change the base?
Conversation
this commit allows to migrate from z2m legacy triggers to experimental event entities
Hey @xeaon, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
fixes #622 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the changes, and it works! Added a comment
# only for zigbee2mqtt, check if the event is relative to a real state change, and not only some minor changes in the sensor attributes | ||
# this is required since multiple state_changed events are fired for a single button press, with the result of the automation being triggered multiple times | ||
- '{{ integration_id != "zigbee2mqtt" or trigger.event.data.new_state.state != trigger.event.data.old_state.state }}' | ||
# - '{{ integration_id != "zigbee2mqtt" or trigger.event.data.new_state.attributes.event_type != trigger.event.data.old_state.attributes.event_type }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this commented out? Isn't this needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict there is no need for this line. i'm testing this for about a week now and everything works as expected
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Breaking change
This change requires you to enable
Home Assistant experimental event entities
in Zigbee2MQTT. Enabling this experimental features may break you current automations, dashboards, etc.Enabling event entities
Event entities in HA
Trace of working automation
Proposed change*
This change allows to make use of event entities in HA. Enabling
Home Assistant experimental event entities
in Zigbee2MQTT will add event entities to your devices, like the ikea_e1744, which we can utilize to define the Controller Entity in this blueprint.Checklist*
npm run format
before submitting my Pull Request.