Skip to content

Commit

Permalink
Major rework of shutdown and reconnect logs to avoid zombie tasks and…
Browse files Browse the repository at this point in the history
… race conditions (Cog-Creators#117)

* Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions

* depends

* cleanup nodes

* rename vars

* missing callbacks

* add a `wait_until_ready` to `lavalink`

* change order to avoid circular imports

* *sigh*

* uhh

* ensure volume persists on a resume

* formatting

* revert task callbacks

* Apply suggestions from code review

Co-authored-by: jack1142 <[email protected]>

* Update lavalink/node.py

Co-authored-by: jack1142 <[email protected]>
  • Loading branch information
Drapersniper and Jackenmen committed Mar 28, 2022
1 parent fbcec12 commit 2d85066
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lavalink/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def _gen_key(self):
self._resume_key.__repr__()
return self._resume_key

async def connect(self, timeout=None, *, shutdown=False):
async def connect(self, timeout: float = None, *, shutdown: bool = False):
"""
Connects to the Lavalink player event websocket.
Expand Down

0 comments on commit 2d85066

Please sign in to comment.