This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #487 from DefinitelyTyped/allow-safe-attw-removals
Do not mark package removals from attw.json as "Edits Infrastructure"
- Loading branch information
Showing
28 changed files
with
853 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| { | ||
| "data": { | ||
| "repository": { | ||
| "id": "MDEwOlJlcG9zaXRvcnk2MDkzMzE2", | ||
| "pullRequest": { | ||
| "id": "PR_kwDOAFz6BM5mMibM", | ||
| "title": "[DO NOT MERGE - infrastructure test] attw.json removal", | ||
| "createdAt": "2024-02-06T22:15:36Z", | ||
| "author": { | ||
| "login": "andrewbranch", | ||
| "__typename": "User" | ||
| }, | ||
| "authorAssociation": "MEMBER", | ||
| "baseRef": { | ||
| "name": "master", | ||
| "__typename": "Ref" | ||
| }, | ||
| "labels": { | ||
| "nodes": [], | ||
| "__typename": "LabelConnection" | ||
| }, | ||
| "isDraft": false, | ||
| "mergeable": "MERGEABLE", | ||
| "number": 68510, | ||
| "state": "OPEN", | ||
| "headRefOid": "073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb", | ||
| "changedFiles": 1, | ||
| "additions": 0, | ||
| "deletions": 1, | ||
| "commitIds": { | ||
| "nodes": [ | ||
| { | ||
| "commit": { | ||
| "oid": "073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb", | ||
| "parents": { | ||
| "nodes": [ | ||
| { | ||
| "oid": "9b8dcf375c4aec95878058c610f8279c22527fa0", | ||
| "__typename": "Commit" | ||
| } | ||
| ], | ||
| "__typename": "CommitConnection" | ||
| }, | ||
| "__typename": "Commit" | ||
| }, | ||
| "__typename": "PullRequestCommit" | ||
| } | ||
| ], | ||
| "__typename": "PullRequestCommitConnection" | ||
| }, | ||
| "timelineItems": { | ||
| "nodes": [], | ||
| "__typename": "PullRequestTimelineItemsConnection" | ||
| }, | ||
| "reviews": { | ||
| "nodes": [], | ||
| "__typename": "PullRequestReviewConnection" | ||
| }, | ||
| "commits": { | ||
| "totalCount": 1, | ||
| "nodes": [ | ||
| { | ||
| "commit": { | ||
| "checkSuites": { | ||
| "nodes": [ | ||
| { | ||
| "databaseId": 20510180479, | ||
| "app": { | ||
| "name": "Azure Pipelines", | ||
| "__typename": "App" | ||
| }, | ||
| "conclusion": null, | ||
| "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb/checks?check_suite_id=20510180479", | ||
| "status": "QUEUED", | ||
| "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb/checks?check_suite_id=20510180479", | ||
| "checkRuns": { | ||
| "nodes": [], | ||
| "__typename": "CheckRunConnection" | ||
| }, | ||
| "createdAt": "2024-02-06T22:14:50Z", | ||
| "workflowRun": null, | ||
| "__typename": "CheckSuite" | ||
| }, | ||
| { | ||
| "databaseId": 20510180503, | ||
| "app": { | ||
| "name": "Dependabot", | ||
| "__typename": "App" | ||
| }, | ||
| "conclusion": null, | ||
| "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb/checks?check_suite_id=20510180503", | ||
| "status": "QUEUED", | ||
| "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb/checks?check_suite_id=20510180503", | ||
| "checkRuns": { | ||
| "nodes": [], | ||
| "__typename": "CheckRunConnection" | ||
| }, | ||
| "createdAt": "2024-02-06T22:14:50Z", | ||
| "workflowRun": null, | ||
| "__typename": "CheckSuite" | ||
| }, | ||
| { | ||
| "databaseId": 20510206482, | ||
| "app": { | ||
| "name": "GitHub Actions", | ||
| "__typename": "App" | ||
| }, | ||
| "conclusion": null, | ||
| "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb/checks?check_suite_id=20510206482", | ||
| "status": "IN_PROGRESS", | ||
| "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb/checks?check_suite_id=20510206482", | ||
| "checkRuns": { | ||
| "nodes": [ | ||
| { | ||
| "title": null, | ||
| "__typename": "CheckRun" | ||
| } | ||
| ], | ||
| "__typename": "CheckRunConnection" | ||
| }, | ||
| "createdAt": "2024-02-06T22:15:40Z", | ||
| "workflowRun": { | ||
| "file": { | ||
| "path": ".github/workflows/CI.yml", | ||
| "__typename": "WorkflowRunFile" | ||
| }, | ||
| "__typename": "WorkflowRun" | ||
| }, | ||
| "__typename": "CheckSuite" | ||
| } | ||
| ], | ||
| "__typename": "CheckSuiteConnection" | ||
| }, | ||
| "status": null, | ||
| "authoredDate": "2024-02-06T22:14:48Z", | ||
| "committedDate": "2024-02-06T22:14:48Z", | ||
| "pushedDate": null, | ||
| "oid": "073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb", | ||
| "__typename": "Commit" | ||
| }, | ||
| "__typename": "PullRequestCommit" | ||
| } | ||
| ], | ||
| "__typename": "PullRequestCommitConnection" | ||
| }, | ||
| "comments": { | ||
| "totalCount": 0, | ||
| "nodes": [], | ||
| "__typename": "IssueCommentConnection" | ||
| }, | ||
| "files": { | ||
| "totalCount": 1, | ||
| "nodes": [ | ||
| { | ||
| "path": "attw.json", | ||
| "additions": 0, | ||
| "deletions": 1, | ||
| "__typename": "PullRequestChangedFile" | ||
| } | ||
| ], | ||
| "pageInfo": { | ||
| "hasNextPage": false, | ||
| "endCursor": "MQ", | ||
| "__typename": "PageInfo" | ||
| }, | ||
| "__typename": "PullRequestChangedFileConnection" | ||
| }, | ||
| "projectCards": { | ||
| "nodes": [], | ||
| "__typename": "ProjectCardConnection" | ||
| }, | ||
| "__typename": "PullRequest" | ||
| }, | ||
| "__typename": "Repository" | ||
| } | ||
| }, | ||
| "loading": false, | ||
| "networkStatus": 7 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "type": "info", | ||
| "now": "2024-02-06T22:16:07.932Z", | ||
| "pr_number": 68510, | ||
| "author": "andrewbranch", | ||
| "headCommitOid": "073ae8d3a0b71b12ba6bb5b7a1d883d8611d98cb", | ||
| "mergeBaseOid": "9b8dcf375c4aec95878058c610f8279c22527fa0", | ||
| "lastPushDate": "2024-02-06T22:15:36.000Z", | ||
| "lastActivityDate": "2024-02-06T22:15:36.000Z", | ||
| "hasMergeConflict": false, | ||
| "isFirstContribution": false, | ||
| "tooManyFiles": false, | ||
| "hugeChange": false, | ||
| "popularityLevel": "Well-liked by everyone", | ||
| "pkgInfo": [ | ||
| { | ||
| "name": null, | ||
| "kind": "edit", | ||
| "files": [ | ||
| { | ||
| "path": "attw.json", | ||
| "kind": "infrastructure" | ||
| } | ||
| ], | ||
| "owners": [], | ||
| "addedOwners": [], | ||
| "deletedOwners": [], | ||
| "popularityLevel": "Critical", | ||
| "isSafeInfrastructureEdit": true | ||
| } | ||
| ], | ||
| "reviews": [], | ||
| "ciResult": "unknown" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| [ | ||
| { | ||
| "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", | ||
| "variables": { | ||
| "input": { | ||
| "subjectId": "PR_kwDOAFz6BM5mMibM", | ||
| "body": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 0 packages in this PR\n\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68510&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 Most recent commit is approved by type definition owners, DT maintainers or others\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "mutation": "mutation ($input: AddProjectCardInput!) {\n addProjectCard(input: $input) {\n __typename\n }\n}\n", | ||
| "variables": { | ||
| "input": { | ||
| "contentId": "PR_kwDOAFz6BM5mMibM", | ||
| "projectColumnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTMw" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", | ||
| "variables": { | ||
| "input": { | ||
| "subjectId": "PR_kwDOAFz6BM5mMibM", | ||
| "body": "🔔 @andrewbranch — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68510/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->" | ||
| } | ||
| } | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "projectColumn": "Waiting for Code Reviews", | ||
| "labels": [], | ||
| "responseComments": [ | ||
| { | ||
| "tag": "welcome", | ||
| "status": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 0 packages in this PR\n\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68510&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 Most recent commit is approved by type definition owners, DT maintainers or others\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." | ||
| }, | ||
| { | ||
| "tag": "pinging-reviewers-others", | ||
| "status": "🔔 @andrewbranch — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68510/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" | ||
| } | ||
| ], | ||
| "shouldClose": false, | ||
| "shouldMerge": false, | ||
| "shouldUpdateLabels": true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.