👷‍♀️ [RUM-7963] Add anonymous user id e2e test and cleanup

[cy-moi]

Motivation

Add e2e tests for anonymous user id and clean up existing tests to distinguish anonymous id from session id in cookies.

Changes

Added new e2e tests
Changed current tests matching regex

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (bfffdaf) to head (a8749e7).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   93.70%   93.68%   -0.02%     
==========================================
  Files         290      290              
  Lines        7652     7654       +2     
  Branches     1745     1745              
==========================================
+ Hits         7170     7171       +1     
- Misses        482      483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BenoitZugmeyer]

❓ question: ‏not sure to see why we need this?

[BenoitZugmeyer]

💬 suggestion: ‏use findSessionCookie here

[BenoitZugmeyer]

💬 suggestion: ‏I think parsing the session cookie in findSessionCookie could make tests easier to implement, with less regexes

Something as simple as

export async function findSessionCookie(): Record<string, string> | undefined {
  const cookies = await browser.getCookies(SESSION_STORE_KEY)
  // In some case, the session cookie is returned but with an empty value. Let's consider it expired
  // in this case.
  const rawValue = cookies[0]?.value
  if (!rawValue) return
  return Object.fromEntries(rawValue.split('&').map(part => part.split("=")))
}

Then in tests:

const anonymousId = (await findSessionCookie())?.aid

Same in unit tests, I think having a utility to quickly parse the cookie instead of relying on regexes would be better.

[BenoitZugmeyer]

💬 suggestion: ‏FMU you have the if (anonymousId) to make TS happy. I don't think we should have this condition:

• even if anonymousId should always be truthy (since we have the assertion above), it makes the test a bit confusing
• you actually want to make the test fail if it was falsy, and not just silently skip the assertion

I think using ! is fine here

Suggested change

	if (anonymousId) {
	expect(await findSessionCookie()).toContain(anonymousId[0])
	}
	expect(await findSessionCookie()).toContain(anonymousId![0])

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	145.98 KiB	145.98 KiB	0 B	0.00%	✅
Logs	51.06 KiB	51.06 KiB	0 B	0.00%	✅
Rum Slim	104.77 KiB	104.77 KiB	0 B	0.00%	✅
Worker	24.50 KiB	24.50 KiB	0 B	0.00%	✅

🚀 CPU Performance

Action Name	Base Average Cpu Time (ms)	Local Average Cpu Time (ms)	𝚫
addglobalcontext	0.003	0.003	0.000
addaction	0.039	0.042	0.003
addtiming	0.001	0.001	0.000
adderror	0.046	0.053	0.007
startstopsessionreplayrecording	0.008	0.012	0.004
startview	0.414	0.424	0.009
logmessage	0.022	0.023	0.001

🧠 Memory Performance

Action Name	Base Consumption Memory (bytes)	Local Consumption Memory (bytes)	𝚫 (bytes)
addglobalcontext	27.33 KiB	28.35 KiB	1.02 KiB
addaction	54.12 KiB	57.62 KiB	3.51 KiB
addtiming	26.15 KiB	26.08 KiB	-67 B
adderror	59.09 KiB	60.53 KiB	1.44 KiB
startstopsessionreplayrecording	24.90 KiB	25.83 KiB	959 B
startview	413.20 KiB	420.59 KiB	7.39 KiB
logmessage	60.18 KiB	63.31 KiB	3.13 KiB

🔗 RealWorld