-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow priority setting, both from picker and parsed via !!! #207
Allow priority setting, both from picker and parsed via !!! #207
Conversation
Makes use of new dependency WrappingHStack to ensure that date, time and priority don't get squooshed. Rather than use a picker (which didn't really look too stylish!) the user clicks to cycle None -> Low -> Medium -> High; the icon updates too.
Entirely functional! That said, if you type too many !s, or type a ! and then delete it, it lingers with a priority, which is a little annoying.
@yunruse Hey, I would do it myself but not a swift programmer, so mostly asking if that would interest you. Thanks |
@AndreaHasani I've never coded in Swift before! It was quite fun; I just sort of cribbed the parser by looking at the interface used in other parsers and hashing out the Swift sufficient to meet the needs here. Swift is pretty elegant so it's not the worst to learn! Sadly EventKit's EKReminder doesn't have any API for tagging reminders :/ |
Very nice addition indeed ! I fully support it for the next release (tested and it works like a charm) |
Thanks for contributing with this feature, @yunruse. |
Added a 'priority' pill to the editor, making use of the dependency WrappingHStack to ensure that this doesn't squoosh up with the date and time pickers. A PriorityParser is added – rather similar to the other Parser objects – so "!!" can be used to impart a priority on the reminder, thereby fixing #195.
ss.2024-06-14.at.00.33.38.mov
This was rather fun to work on 😅 I hope this barrage of pull requests isn't annoying!