-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change StorageDevice to contain a data path and disk quota #40
base: develop
Are you sure you want to change the base?
Conversation
Ensemble with |
added @gcrone as reviewer since he originally introduced the storage device class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original intent was that the StorageDevice
class describes the physical hardware available on the machine. Should the quota
and data_path
be in a separate class defining how the StoarageDevice
is used by the software?
My thinking here was that systems could have multiple StorageDevices (e.g. /data1, /data2, ...), and the only reason we would care about their size is if we wanted to impose a limit on how much of it a given Session could use at a time. If you look at the associated |
I can see that the idea of quota and the actual data path are things that you want in the database. The point was that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
No description provided.