Disable consolelogger, add tracking issue #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
approved these changes
Aug 2, 2024
|
Looks like testspace got stuck, I'll rerun |
|
Yeah, I'm not too sure what's going on. It's like its saying the number of tests are different, which is weird with this type of change. But I do see the numbers being different, but not sure why that is the case... (number of test cases run) |
|
Closing to kick off fresh build...? |
|
Sending mail to testspace to get more, but this seems to be an issue with how the test logs are being uploaded and bucketed, everything is passing in the CI. Going to merge this and follow-up with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled consolelogger in our solution generation script to avoid microsoft/slngen#451 until it is fixed