-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Add [SupportedOSPlatform]
to AppBuilderExtensions
#2488
[Housekeeping] Add [SupportedOSPlatform]
to AppBuilderExtensions
#2488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.cs: Evaluated as low risk
src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sweet! I am happy to see the build message about versions being put to rest for all those messages.
Description of Change
This PR adds the
[SupportedOSPlatform]
attribute to eachAppBuilderExtensions
file, declaring the minimum supported operating system version for each platform as supported by the .NET MAUI Community Toolkit(s).This ensures that users are warned immediately when using any
CommunityToolkit.Maui.*
library that they may be targeting an unsupported version of iOS/Android/Windows/MacCatalyst/Tizen when initializing the toolkit. This PR follows the existing implementation set inCommunityToolkit.Maui.Camera.AppBuilderExtensions
.It's basically an easy way for us to notify developers regrading which platforms we support without requiring them to read the Release Notes.
PR Checklist
main
at time of PRAdditional information
The version numbers align with the
SupportedOSPlatformVersion
noted in each library's csproj:Maui/src/CommunityToolkit.Maui/CommunityToolkit.Maui.csproj
Lines 21 to 26 in fa4004d
This PR also renames
CommunityToolkit.Maui.Maps.AppHostBuilderExtension
->CommunityToolkit.Maui.Maps.AppBuilderExtension
to align with the naming used inCommunityToolkit.Maui
,CommunityToolkit.Maui.Core
,CommunityToolkit.Maui.MediaElement
andCommunityToolkit.Maui.Camera
.