Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to define when the IconTintBehavior gets applied #2304

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

bijington
Copy link
Contributor

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@dotnet-policy-service dotnet-policy-service bot added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Jan 17, 2025
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have reviewed the changes. I have tested it on windows, ios, and android. It works as expected and fixes the bug reported. This looks good to go.

@ne0rrmatrix ne0rrmatrix enabled auto-merge (squash) February 4, 2025 22:42
@ne0rrmatrix ne0rrmatrix merged commit af82af8 into main Feb 4, 2025
10 checks passed
@ne0rrmatrix ne0rrmatrix deleted the feature/sl-1975-more-behavior-application-options branch February 4, 2025 23:18
@TheCodeTraveler
Copy link
Collaborator

TheCodeTraveler commented Feb 4, 2025

@bijington Could you jump on the documentation for this ASAP?

@ne0rrmatrix This PR introduces a new API and should not have been merged before a Pull Request was opened in our Docs Repo.

Update: This merged PR was reverted. The new PR is available here: https://github.com/CommunityToolkit/Maui/pull/2495/files

@TheCodeTraveler TheCodeTraveler added pending documentation This feature requires documentation needs discussion Discuss it on the next Monthly standup and removed help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days labels Feb 4, 2025
@TheCodeTraveler
Copy link
Collaborator

TheCodeTraveler commented Feb 4, 2025

@bijington Could you also open a new PR that updates our sample app to demonstrate this option? We will use this for both demo purposes and regression testing in the future.

Update: This merged PR was reverted. The new PR is available here: https://github.com/CommunityToolkit/Maui/pull/2495/files

@TheCodeTraveler
Copy link
Collaborator

TheCodeTraveler commented Feb 4, 2025

After speaking with James, I'm going to revert this PR and re-open it since it wasn't tested and isn't yet documented.

Update: This merged PR was reverted. The new PR is available here: https://github.com/CommunityToolkit/Maui/pull/2495/files

TheCodeTraveler added a commit that referenced this pull request Feb 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs discussion Discuss it on the next Monthly standup pending documentation This feature requires documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IconTintColorBehavior is reset when navigate to another page then back
3 participants