-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to define when the IconTintBehavior gets applied #2304
Make it possible to define when the IconTintBehavior gets applied #2304
Conversation
...unityToolkit.Maui/Behaviors/PlatformBehaviors/IconTintColor/IconTintColorBehavior.android.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have reviewed the changes. I have tested it on windows, ios, and android. It works as expected and fixes the bug reported. This looks good to go.
@bijington Could you jump on the documentation for this ASAP? @ne0rrmatrix This PR introduces a new API and should not have been merged before a Pull Request was opened in our Docs Repo. Update: This merged PR was reverted. The new PR is available here: https://github.com/CommunityToolkit/Maui/pull/2495/files |
@bijington Could you also open a new PR that updates our sample app to demonstrate this option? We will use this for both demo purposes and regression testing in the future. Update: This merged PR was reverted. The new PR is available here: https://github.com/CommunityToolkit/Maui/pull/2495/files |
After speaking with James, I'm going to revert this PR and re-open it since it wasn't tested and isn't yet documented. Update: This merged PR was reverted. The new PR is available here: https://github.com/CommunityToolkit/Maui/pull/2495/files |
Description of Change
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information