-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to auto-use default HTTP(S) port for Lavalink #5629
Conversation
What to testScenario 1: It should connect successfully Scenario 2: Scenario 3 Scenario 4 Scenario 5 What to expect1 - Scenario 1 user is able to connect successfully and play music |
8e5509b
to
89a86d6
Compare
e0f5998
to
b4c489c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…tors#5629) Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: Kreusada <[email protected]>
Description of the changes
Users are now allowed to set port to
-1
which will automatically set the connection ports to80/443
depending on the security settings.Sorry but you cannot test the 443 part of it as it is added on #5593
Have the changes in this PR been tested?
Yes