Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Promise Tracker UI Breaking imports #1033

Merged
merged 10 commits into from
Jan 31, 2025
Merged

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Jan 22, 2025

Description

This PR Fixes issues with Promise Tracker which failed since migration from mui 4.

  • Reverts Formik MUI to v4.0.0 which causes some breaks.
  • Replaces undefined with null for serialization.
  • Adds Promise Tracker builder to docker for easy testing
  • Fixes failing import location for create theme.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Jan 22, 2025
@koechkevin koechkevin marked this pull request as draft January 22, 2025 09:32
@kilemensi
Copy link
Member

What's the holdup on this @koechkevin ?

@koechkevin
Copy link
Contributor Author

What's the holdup on this @koechkevin ?

@kilemensi I got pnpm dev working but ran into an issue with pnpm build
image

I need to have this updated to build like the other apps.

@koechkevin koechkevin marked this pull request as ready for review January 28, 2025 14:51
@koechkevin koechkevin requested a review from a team January 29, 2025 10:44
@koechkevin
Copy link
Contributor Author

@CodeForAfrica/tech

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀


I think the PR is getting too big to do a proper review so lets proceed. However, the chart on the homepage still doesn't render for me. If it's a known problem, add a separate issue to track and fix it.
Screenshot 2025-01-31 at 12 43 20

@koechkevin koechkevin added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 519afd8 Jan 31, 2025
5 of 6 checks passed
@koechkevin koechkevin deleted the promise-tracker-update branch January 31, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants