Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Material UI version from 5.16.6 => 6.4.0 #1031

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Jan 16, 2025

Description

This PR upgrades Material UI (MUI) from version 5 to version 6 and updates all related Jest snapshots. The upgrade ensures compatibility with the latest features, performance improvements, and bug fixes introduced in MUI v6.

This PR does not include apps that still use deprecated JSS. PromiseTracker and PesaYetu may fail when testing this PR and fixes are handled on separate PRs.

Fixes #1030

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Jan 16, 2025
@koechkevin koechkevin marked this pull request as draft January 16, 2025 09:03
pnpm-workspace.yaml Outdated Show resolved Hide resolved
@koechkevin koechkevin requested a review from a team January 23, 2025 11:31
@koechkevin koechkevin marked this pull request as ready for review January 23, 2025 11:31
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ... looks good.


  1. Can we make sure all PROD apps (charterafrica and civicsignalblog specifically) actually build (not only run)? charterafrica is failing on my end but it could be my setup
  2. climatemappedafrica runs (dev) but has a warning:
 ⚠ Invalid next.config.js options detected:
 ⚠     Unrecognized key(s) in object: 'outputFileTracingRoot' at "experimental"
 ⚠ See more info here: https://nextjs.org/docs/messages/invalid-next-config

@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label Jan 23, 2025
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koechkevin
Copy link
Contributor Author

@CodeForAfrica/tech

@kilemensi
Copy link
Member

If the issues above have been addressed @koechkevin , lets merge this.

@koechkevin koechkevin added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit d3ad662 Jan 24, 2025
5 of 6 checks passed
@koechkevin koechkevin deleted the chore_bump_material_ui branch January 24, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that needs to be done (neither enhancement or bug)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Chore: Update Material UI to v6
3 participants