-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Material UI version from 5.16.6 => 6.4.0 #1031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilemensi
reviewed
Jan 23, 2025
…ped, update component snapshots
kilemensi
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 ... looks good.
- Can we make sure all PROD apps (charterafrica and civicsignalblog specifically) actually build (not only run)? charterafrica is failing on my end but it could be my setup
- climatemappedafrica runs (dev) but has a warning:
⚠ Invalid next.config.js options detected:
⚠ Unrecognized key(s) in object: 'outputFileTracingRoot' at "experimental"
⚠ See more info here: https://nextjs.org/docs/messages/invalid-next-config
apps/promisetracker/src/components/Navigation/MobileNavigation/NavigationList.js
Outdated
Show resolved
Hide resolved
kilemensi
added
the
chore
A task that needs to be done (neither enhancement or bug)
label
Jan 23, 2025
…st component structure
kelvinkipruto
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@CodeForAfrica/tech |
If the issues above have been addressed @koechkevin , lets merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Material UI (MUI) from version 5 to version 6 and updates all related Jest snapshots. The upgrade ensures compatibility with the latest features, performance improvements, and bug fixes introduced in MUI v6.
This PR does not include apps that still use deprecated JSS. PromiseTracker and PesaYetu may fail when testing this PR and fixes are handled on separate PRs.
Fixes #1030
Type of change
Screenshots
Checklist: