Skip to content

Commit

Permalink
Revert to d3-format
Browse files Browse the repository at this point in the history
  • Loading branch information
kelvinkipruto committed Oct 8, 2024
1 parent 911f84e commit 2d822e1
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 16 deletions.
1 change: 1 addition & 0 deletions apps/climatemappedafrica/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"@reactour/tour": "catalog:",
"aws-sdk": "catalog:",
"clsx": "catalog:",
"d3-format": "catalog:",
"deepmerge": "catalog:",
"express": "catalog:",
"leaflet": "catalog:",
Expand Down
19 changes: 11 additions & 8 deletions apps/climatemappedafrica/src/utils/formatNumericalValue.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
import { format } from "d3-format";

import { hurumap } from "@/climatemappedafrica/config";

function formatNumericalValue({ value, method }) {
let options = {};
const { formatting } = hurumap;
let fn = format(formatting.percentage);
// Percentage formatting multiplies by 100 first.
// see: https://github.com/d3/d3-format#locale_format
let multipler = 100;

if (method === "absolute_value") {
options = { style: "decimal", maximumFractionDigits: 0 };
fn = format(formatting.integer);
multipler = 1;
} else if (method === "decimal") {
options = { style: "decimal", maximumFractionDigits: 2 };
multipler = 1;
} else {
options = { style: "percent", maximumFractionDigits: 2 };
fn = format(formatting.decimal);
}

const formatter = new Intl.NumberFormat(undefined, options);
return formatter.format(value / multipler);
return fn(value / multipler);
}

export default formatNumericalValue;
1 change: 1 addition & 0 deletions apps/pesayetu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"@reactour/tour": "catalog:",
"aws-sdk": "catalog:",
"clsx": "catalog:",
"d3-format": "catalog:",
"deepmerge": "catalog:",
"leaflet": "catalog:",
"lodash": "catalog:",
Expand Down
19 changes: 11 additions & 8 deletions apps/pesayetu/src/utils/formatNumericalValue.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
import { format } from "d3-format";

import { hurumap } from "@/pesayetu/config";

function formatNumericalValue({ value, method }) {
let options = {};
const { formatting } = hurumap;
let fn = format(formatting.percentage);
// Percentage formatting multiplies by 100 first.
// see: https://github.com/d3/d3-format#locale_format
let multipler = 100;

if (method === "absolute_value") {
options = { style: "decimal", maximumFractionDigits: 0 };
fn = format(formatting.integer);
multipler = 1;
} else if (method === "decimal") {
options = { style: "decimal", maximumFractionDigits: 2 };
multipler = 1;
} else {
options = { style: "percent", maximumFractionDigits: 2 };
fn = format(formatting.decimal);
}

const formatter = new Intl.NumberFormat(undefined, options);
return formatter.format(value / multipler);
return fn(value / multipler);
}

export default formatNumericalValue;
9 changes: 9 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2d822e1

Please sign in to comment.