-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security fix: Added nonce check to CSV importer actions #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for email 3c35038 should not be in this PR. Could you remove 3c35038
?
Backport from woocommerce/woocommerce@cabf9de See also #214
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
============================================
- Coverage 40.83% 40.82% -0.01%
Complexity 13447 13447
============================================
Files 367 367
Lines 51275 51280 +5
============================================
- Hits 20938 20936 -2
- Misses 30337 30344 +7
Continue to review full report at Codecov.
|
Testing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared the changes here against woocommerce/woocommerce@cabf9de and this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the branch locally and imported a number of assets using a dummy csv and txt. So all looks fine for user endpoint.
woocommerce/woocommerce@cabf9de
See also #214
Files affected:
includes/admin/class-wc-admin-importers.php
includes/admin/importers/class-wc-product-csv-importer-controller.php