Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built assets from git #688

Closed
wants to merge 5 commits into from
Closed

Remove built assets from git #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc19660
Remove built assets from repo
jshjohnson Oct 24, 2019
698ebf4
Add predeploy hook
jshjohnson Oct 24, 2019
bbdf3d3
Add gitkeep to built dirs
jshjohnson Oct 24, 2019
c612c69
Update gitignore to have correct path
jshjohnson Oct 24, 2019
37b6bb4
Re-add PR number to code cov command
jshjohnson Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
-f ./coverage/lcov.info
-B ${{ github.head_ref }}
-C ${{ github.sha }}
-P ${{ github.event.number }}
-Z || echo 'Codecov upload failed'
env:
CI: true
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ npm-debug.log
.DS_Store
.idea

# Built assets
public/assets/styles
public/assets/scripts

# Test
tests/reports
tests/results
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"css:sass": "node-sass --output-style expanded --include-path scss src/styles/base.scss public/assets/styles/base.css && node-sass --output-style expanded --include-path scss src/styles/choices.scss public/assets/styles/choices.css",
"css:prefix": "postcss public/assets/styles/*.css --use autoprefixer --no-map --env prod --dir public/assets/styles",
"css:min": "csso public/assets/styles/base.css --output public/assets/styles/base.min.css && csso public/assets/styles/choices.css --output public/assets/styles/choices.min.css",
"predeploy": "npm run build",
"deploy": "git subtree push --prefix public origin gh-pages",
"prepush": "run-s lint test:unit bundlesize",
"postversion": "git push --no-verify --atomic --follow-tags",
Expand Down
Empty file added public/assets/scripts/.gitkeep
View file
Open in desktop
Empty file.
Loading