Update Avalonia UI features #967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GoBack method in ShellViewModel.cs for back navigation using _navigationService. Updated NavigationSourceView.axaml and NavigationTargetView.axaml to replace placeholder text with structured UI elements. Enhanced ShellView.axaml with Window.Resources for icons and updated StackPanel for navigation buttons. Added navigationStack and navigationStackIndex in NavigationFrame.cs to manage navigation history. Implemented GoBackAsync and NavigateToViewModelAsync<T> methods in NavigationFrame.cs. Added TryInjectParameters method for parameter injection into view models. Included logging statements in NavigationFrame.cs for detailed navigation actions.
Introduce `addToStack` parameter in `NavigateToViewModel` to control whether the view model is added to the navigation stack. Update `GoBackAsync` to pass `false` for `addToStack`, preventing the view model from being added to the stack when navigating back. Enhance navigation logic for better stack management.
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- samples/features/Features.Avalonia/Views/NavigationSourceView.axaml: Language not supported
- samples/features/Features.Avalonia/Views/NavigationTargetView.axaml: Language not supported
- samples/features/Features.Avalonia/Views/ShellView.axaml: Language not supported
Comments suppressed due to low confidence (1)
src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/NavigationFrame.cs:19
- [nitpick] The variable name navigationStackIndex should be checked for consistency with the rest of the codebase.
private List<object> navigationStack = new List<object>();
src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/NavigationFrame.cs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/NavigationFrame.cs
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- samples/features/Features.Avalonia/Views/NavigationSourceView.axaml: Language not supported
- samples/features/Features.Avalonia/Views/NavigationTargetView.axaml: Language not supported
- samples/features/Features.Avalonia/Views/ShellView.axaml: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance navigation functionality and improve the user interface in the Avalonia application. The most important changes include the addition of a
GoBackmethod, updates to navigation views, UI improvements, and enhancements to theNavigationFrameclass.Enhancements to navigation functionality:
samples/features/Features.Avalonia/ViewModels/ShellViewModel.cs: Added a newGoBackmethod to handle backward navigation.src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/NavigationFrame.cs: Implemented navigation stack management and theGoBackAsyncmethod to support backward navigation. [1] [2] [3]Updates to navigation views:
samples/features/Features.Avalonia/Views/NavigationSourceView.axaml: Replaced placeholder text with aGridcontaining aTextBox,CheckBox, andButton.samples/features/Features.Avalonia/Views/NavigationTargetView.axaml: Replaced placeholder text with aGridcontaining twoTextBlockelements.UI improvements:
samples/features/Features.Avalonia/Views/ShellView.axaml: AddedStreamGeometryresources for icons and updated theStackPanelbackground with a gradient. AddedPathIconelements to theGoBackandGoHomebuttons for improved visual representation.Enhancements to parameter handling:
src/Caliburn.Micro.Platform/Platforms/netcore-avalonia/NavigationFrame.cs: Added theTryInjectParametersmethod to inject query string parameters into the view model.Closing #966