OnUIThread-Refactor and a few improvements #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gedBase.cs) to remove code duplication. - Added documentation in (RegExHelper.cs) for NameRegEx (Hover over NameRegEx to see the result). - Changed action variables to Local functions. - Changed nested private classes to be sealed. - Inlined the out parameters. - Used Pattern matching whenever applicable. - Used Compound assignment whenever applicable. - Used nameof to avoid magic strings. - Removed this Keyword whenever possible. - Removed Zombie code. - Removed unnecessary using directives. - Remoced #region preprocessor directives. - Reformat Curly Braces - Fixed couple of typos.
vb2ae
reviewed
Jan 14, 2025
vb2ae
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to improve parts of the codebase for better readability and to fix the compiler warnings.
I think this pull request should be easy to review since the changes in the files are at minimum.
The code in "Platforms" can be improved, but will need extra work to be done.
You can take notes from this pull request without merging it, I don't mind that.
Summary of changes:
SafeRun in Action
Regex Documentation