Initial implementation of WinUI with samples and features working #853
Conversation
|
@KasperSK do you want to complete this pr? |
Yes but I think I need to make another commit and fix the small issues. :) |
|
Just wondering how far off we are from seeing this in a release? I've been using caliburn.micro in WPF apps for nearly 8 years, but I'm currently working on a WinUI app, and the amount of non-sense you have to do for basic View/ViewModel binding (and the amount of concrete references you need to have from the view to the view model) is just staggering after working in a fully auto-wired caliburn app... |
|
@vb2ae Do you still think we should merge this if I rebase the PR? |
|
yes we can fix any bug we find |
|
@KasperSK thanks |
Updated README.md to reflect changes in description and package details. Modified `MessageDialogResult.cs` to use `_content` and `_title`. Updated `App.xaml` and `App.xaml.cs` with XML declaration, removed comments, and added navigation to `MenuView`. Updated `Features.WinUI3.csproj` to target .NET 8.0 and adjusted settings. Cleaned up `RootView.xaml.cs` and other files by removing unused directives. Updated `Package.appxmanifest` and `app.manifest` for Windows 10 compatibility. Renamed bindings in `ActionsView.xaml`, `NavigationSourceView.xaml`, and `NavigationTargetView.xaml`. Updated `Microsoft.NET.Test.Sdk` and `Nerdbank.GitVersioning` packages. Improved formatting and consistency in several files. Added strong name key files.
Feature/winui update
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Caliburn.Micro.Platform/Platforms/uap/DispatcherQueueExtentions.cs
Dismissed
Show dismissed
Hide dismissed
src/Caliburn.Micro.Platform/Platforms/uap/DispatcherQueueExtentions.cs
Dismissed
Show dismissed
Hide dismissed
src/Caliburn.Micro.Platform/Platforms/uap/DispatcherQueueExtentions.cs
Dismissed
Show dismissed
Hide dismissed
src/Caliburn.Micro.Platform/Platforms/uap/DispatcherQueueExtentions.cs
Dismissed
Show dismissed
Hide dismissed
I will get on that :) |
There was a problem hiding this comment.
Copilot reviewed 110 out of 125 changed files in this pull request and generated no comments.
Files not reviewed (15)
- samples/features/Features.Avalonia/Features.Avalonia.csproj: Language not supported
- samples/features/Features.UWP/Features.UWP.csproj: Language not supported
- samples/features/Features.WinUI3/App.xaml: Language not supported
- samples/features/Features.WinUI3/Features.WinUI3.csproj: Language not supported
- samples/features/Features.WinUI3/MainWindow.xaml: Language not supported
- samples/features/Features.WinUI3/Package.appxmanifest: Language not supported
- samples/features/Features.WinUI3/Views/ActionsView.xaml: Language not supported
- samples/features/Features.WinUI3/Views/Activity/MessageActivityView.xaml: Language not supported
- samples/features/Features.WinUI3/Views/Activity/PhotoActivityView.xaml: Language not supported
- samples/features/Features.WinUI3/Views/BindingsView.xaml: Language not supported
- README.md: Evaluated as low risk
- samples/features/Features.CrossPlatform.Shared/Results/VisualStateResult.cs: Evaluated as low risk
- .github/workflows/dotnet.yml: Evaluated as low risk
- samples/features/Features.CrossPlatform.Shared/Results/MessageDialogResult.cs: Evaluated as low risk
- samples/features/Features.WinUI3/Views/Activity/PhotoActivityView.xaml.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
samples/features/Features.WinUI3/MainWindow.xaml.cs:31
- [nitpick] The variable name myButton is ambiguous. It should be renamed to submitButton.
private void myButton_Click(object sender, RoutedEventArgs e)
|
Thanks Ken, I have not had any time over the holidays. I will merge this and then we should work with WinUI 3 :) |
|
@KasperSK no problem. Hope you enjoyed the holidays |
This works but navigation is a little rough around the edges, open for input on how it should be done for WinUI