Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dimension type from constructor instead of calling getDimension #510

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: use dimension type from constructor instead of calling getDimension #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/main/java/me/jellysquid/mods/lithium/mixin/world/inline_height/WorldMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import net.minecraft.world.World;
import net.minecraft.world.dimension.DimensionType;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
Expand All @@ -21,9 +20,6 @@
*/
@Mixin(World.class)
public abstract class WorldMixin implements HeightLimitView {
@Shadow
public abstract DimensionType getDimension();

private int bottomY;
private int height;
private int topYInclusive;
Expand All @@ -32,9 +28,9 @@ public abstract class WorldMixin implements HeightLimitView {
method = "<init>",
at = @At("RETURN")
)
private void initHeightCache(MutableWorldProperties properties, RegistryKey<?> registryRef, DynamicRegistryManager registryManager, RegistryEntry<?> dimensionEntry, Supplier<?> profiler, boolean isClient, boolean debugWorld, long biomeAccess, int maxChainedNeighborUpdates, CallbackInfo ci) {
this.height = this.getDimension().height();
this.bottomY = this.getDimension().minY();
private void initHeightCache(MutableWorldProperties properties, RegistryKey<?> registryRef, DynamicRegistryManager registryManager, RegistryEntry<DimensionType> dimensionEntry, Supplier<?> profiler, boolean isClient, boolean debugWorld, long biomeAccess, int maxChainedNeighborUpdates, CallbackInfo ci) {
this.height = dimensionEntry.value().height();
this.bottomY = dimensionEntry.value().minY();
this.topYInclusive = this.bottomY + this.height - 1;
}

Expand Down
Loading