Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added STIDC and UTIDC registers #247

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Added STIDC and UTIDC registers #247

wants to merge 5 commits into from

Conversation

francislaus
Copy link

This PR adds the SCRs for supervisor and user thread ID capability registers, which are used in compartmentalisation.

@francislaus francislaus self-assigned this Apr 18, 2024
@francislaus francislaus marked this pull request as ready for review April 26, 2024 09:36
@francislaus francislaus requested a review from qwattash April 26, 2024 09:36
qwattash
qwattash approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@qwattash qwattash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm not sure why the Morello test is failing though.
Checkpatch complains about // comments but all files uses them, I don't see much of a point to have multiple comment styles here just for that.

@arichardson
Copy link
Member

The current spec has UTID as a view of STID (and no MTID at all), do we want to match that instead?

@jrtc27
Copy link
Member

jrtc27 commented May 8, 2024

The current spec has UTID as a view of STID (and no MTID at all), do we want to match that instead?

That's being changed, it was a bad idea to not have a separate ID register for S-mode's own use

jrtc27
jrtc27 reviewed May 9, 2024
View reviewed changes
target/riscv/op_helper_cheri.c Outdated Show resolved Hide resolved
target/riscv/op_helper_cheri.c Outdated Show resolved Hide resolved
arichardson
arichardson approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

target/riscv/op_helper_cheri.c Outdated Show resolved Hide resolved
target/riscv/op_helper_cheri.c Outdated Show resolved Hide resolved
target/riscv/op_helper_cheri.c Outdated Show resolved Hide resolved
arichardson
arichardson approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise lgtm

target/riscv/op_helper_cheri.c Outdated Show resolved Hide resolved
arichardson
arichardson approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and squash? Then we can merge this to dev.

@arichardson arichardson changed the base branch from qemu-cheri to dev February 5, 2025 19:09
@francislaus francislaus force-pushed the faf28_tid branch 2 times, most recently from c5e6c12 to 9d87356 Compare February 6, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrtc27 jrtc27 jrtc27 left review comments

@arichardson arichardson arichardson approved these changes

@qwattash qwattash qwattash approved these changes

Assignees

@francislaus francislaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francislaus @arichardson @jrtc27 @qwattash