-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use the new #classicwebcam_container
#39
base: master
Are you sure you want to change the base?
fix: Use the new #classicwebcam_container
#39
Conversation
Since OctoPrint/OctoPrint#4628 we need to use `#classicwebcam_container` otherwise all controls and text information provided by this plugin is `display:none`.
thank you for the fix, mike! |
@BillyBlaze can you merge? |
I recently upgraded my OctoPrint instance and had this issue too. I opened #41 to see if there is any response. If not, @MikeRatcliffe can you imagine to adopt the plugin and give it a new home? |
@lordofbikes I would imaging that you are busy enough with LibreCAD, so I am happy to take over as maintainer for this plugin. Note to self: if @BillyBlaze doesn't respond to #41 by 4 Mar 2024 then I will need to follow https://github.com/OctoPrint/plugins.octoprint.org/pull/651/files in order to add myself as the new maintainer. In the meantime, I will update the code in my repo to use more modern methods. |
Thank you, it's working ! |
Since OctoPrint/OctoPrint#4628 we need to use
#classicwebcam_container
otherwise all controls and text information provided by this plugin isdisplay:none
.Fixes #38 (Landed in OctoPrint v1.9.0)