Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SH view space #16094

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jan 22, 2025

Fix viewdirection to make SH computation happen in GS local coordinates.

Tested with https://playground.babylonjs.com/#CID4NN#278

set ofs to true to add a rotation and translation offset. Rendering should be the same with of without this offset.

NOTE : I'll wait for partners feedback before merging it.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 22, 2025

@sebavan sebavan marked this pull request as draft January 22, 2025 19:16
@sebavan
Copy link
Member

sebavan commented Jan 22, 2025

Converted as draft while you are awaiting partner feedback but looks all good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants