Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test go #32023

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

test go #32023

wants to merge 6 commits into from

Conversation

richardpark-msft
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 7, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is labelled with ArcReview. For this PR to be merged, it must pass an ARC review and be labelled ArcSignedOff.
    Email the ARC board to request review per this Contact section.
  • ❌ The required check named SpellCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 7, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=68f93a25dd774809bed7a818b32a3420
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=050fa17963a24704b81148bbf5f15e26

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 7, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.EventGrid
Azure.Batch
ContentSafety
Microsoft.DatabaseWatcher
Language.Conversations.Authoring
Language.AnalyzeDocuments
Language.Text
Language.Text.Authoring
Language.Conversations
Azure.OpenAI
Microsoft.StandbyPool
Microsoft.ContainerService
Microsoft.PlaywrightTesting.AuthManager
Microsoft.AzurePlaywrightService

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Jan 7, 2025
This was referenced Jan 7, 2025
Draft
Draft
Draft
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview removed the TypeSpec Authored with TypeSpec label Jan 7, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Jan 10, 2025
This was referenced Jan 10, 2025
Draft
Draft
@richardpark-msft
Copy link
Member Author

(just trying out things from here: #32118)

@richardpark-msft
Copy link
Member Author

Had a typo - needed to remove resourcemanager from my config. Also, added in the other attributes that are coming up in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel will be requested when the pull request is marked ready for review lmazuel is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire will be requested when the pull request is marked ready for review jsquire is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft will be requested when the pull request is marked ready for review JoshLove-msft is a code owner

@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence will be requested when the pull request is marked ready for review l0lawrence is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Alerts Management Analysis Services API Management ArcReview Authorization Automation Batch BatchAI Billing Cognitive - Language Cognitive Services Compute Container Instances Container Registry Container Service Cosmos Customer Insights Data Factory Data Lake Analytics Data Lake Store Data Migration Device Update Device Update Service Devtestlab Event Grid Event Hubs HDInsight Import Export Insights Intune IoTHub KeyVault Load Test Service Azure Load Test Service Logic App Machine Learning Compute Machine Learning Maps Media Services Mobile Engagement Monitor - Exporter Monitor OpenTelemetry Exporter Monitor - Operational Insights Monitor Monitor, Monitor Ingestion, Monitor Query MySQL Network - CDN Network - DNS Network - Traffic Manager Network Notification Hub Operations Management Peering Policy Insights PostgreSQL Profile Azure API profile issues. Purview Recovery Services Backup Recovery Services Site-Recovery RecoveryServices Redis Cache Relay Scheduler Search Service Bus Service Fabric Service Map SQL Storage Storage Service (Queues, Blobs, Files) StorageSync Storsimple Stream Analytics Subscription Synapses TimeseriesInsights TypeSpec Authored with TypeSpec Web Apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardpark-msft @azure-sdk @AzureRestAPISpecReview