-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle C# SDK Naming Requirements for Autogenerated Specs #32006
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Adding this issue for tracking: Azure/azure-sdk-for-net#45949 |
|
||
#suppress "@azure-tools/typespec-azure-core/casing-style" | ||
namespace Microsoft.IoTOperations { | ||
@@access(Operations.list, Access.internal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workaround is not needed anymore, generator can remove the list operation properly.
Ignore the |
@@access(Operations.list, Access.internal); | ||
|
||
@@clientName(CertManagerCertOptions, "CertManagerCertConfig", "csharp"); | ||
@@clientName(DataflowOperation, "DataflowConfig", "csharp"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Config is the right substitute here. What about DataflowAction?
SDK configuration pull request
Purpose of this PR
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
tspconfig.yaml
templates:Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.