Adding new ACA Session Data Plane APIs #31996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
shivamkm07
changed the title
|
Thank you for your contribution shivamkm07! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This was referenced Jan 6, 2025
BlackRider97
reviewed
Jan 7, 2025
| "body": { | ||
| "sessions": [ | ||
| { | ||
| "identifier": "testid1", |
There was a problem hiding this comment.
why response body don't have other properties like GET resource object ?
"body": {
"createdAt": "2025-01-05T22:18:41.585Z",
"lastAccessedAt": "2025-01-05T22:18:41.585Z",
"expireAt": "2025-01-05T22:18:41.585Z",
"etag": "123456789"
}
```
| "createdAt": "2025-01-05T22:18:41.585Z", | ||
| "lastAccessedAt": "2025-01-05T22:18:41.585Z", | ||
| "expireAt": "2025-01-05T22:18:41.585Z", | ||
| "etag": "123456789" |
There was a problem hiding this comment.
instead of this, can you add some real etag example value ?
| "createdAt": "2025-01-05T22:18:41.495Z", | ||
| "lastUpdatedAt": "2025-01-05T22:18:41.495Z", | ||
| "jupyterKernel": { | ||
| "name": "deno", |
| } | ||
|
|
||
| @doc("The sessions list response entry.") | ||
| model SessionsListResponseEntry { |
There was a problem hiding this comment.
why it is different from GET ?
| @get | ||
| get is Foundations.Operation<SessionIdentifier, Session>; | ||
|
|
||
| #suppress "@azure-tools/typespec-azure-core/use-standard-operations" "No suitable standard operation found." |
There was a problem hiding this comment.
Can't we avoid these suppression as it means they are not following standard pattern ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Related PR: https://msazure.visualstudio.com/One/_git/AAPT-Antares-Containerapps/pullrequest/11352385
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.