Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotcom Pages Modal: Update order of patterns to show theme patterns first #89727

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Apr 22, 2024

Related to pdKhl6-37D-p2#comment-6213

Proposed Changes

  • Update the order of patterns to show theme patterns first
BEFORE AFTER
Screenshot 2567-04-22 at 18 43 01 Screenshot 2567-04-22 at 18 43 36

Next tasks for the pages modal

Post a P2 with these and more opportunities to improve this modal:

  • Order page categories using the same order as in Assembler
  • Add a custom hook to allow disabling the modal and show the core modal instead
  • Improve the layout to list patterns horizontally rather than vertically:
    • so all theme patterns can appear in the same row
    • this will improve the loading effect too
    • the pattern explorer in core seems to work in this way and uses the height of the taller pattern for the row

Testing Instructions

  • Sandbox a site
  • Patch this PR in your sandbox with install-plugin.sh etk fix/add-page-modal
  • Active TT4 in your site or any other theme with full-page patterns
  • Create a new page from the admin { SITE }/wp-admin/post-new.php?post_type=page
  • Verify the page patterns appear at the top of any of their categories

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@miksansegundo miksansegundo requested a review from a team April 22, 2024 09:52
@miksansegundo miksansegundo self-assigned this Apr 22, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 22, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/add-page-modal on your sandbox.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as described!

@miksansegundo miksansegundo merged commit abb3e5b into trunk Apr 23, 2024
14 of 15 checks passed
@miksansegundo miksansegundo deleted the fix/add-page-modal branch April 23, 2024 03:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 23, 2024
@miksansegundo
Copy link
Contributor Author

Next tasks are related to WordPress/gutenberg#56944

For the curious, WebKit is pushing the creation of a native Masonry layout. See https://webkit.org/blog/15269/help-us-invent-masonry-layouts-for-css-grid-level-3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants