Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dispatcher to use Outbox #1186

Merged
merged 37 commits into from
Jan 23, 2025
Merged

Update Dispatcher to use Outbox #1186

merged 37 commits into from
Jan 23, 2025

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Jan 20, 2025 •
edited
Loading

Simple dispatcher based on the Outbox-Collection.

This is a simple rewrite of the current dispatcher system, to use the Outbox instead of the Scheduler.

This is a first draft and will be improved over time, to better handle:

  • Re-tries
  • Errors
  • Logging
  • Batch processing

@mattwiebe
Copy link
Contributor

This is a first draft and will be improved over time, to better handle:

  • Re-tries
  • Errors
  • Logging
  • Batch processing

I'm going to take on some or all of those, let's see how far I get.

@pfefferle pfefferle self-assigned this Jan 21, 2025
@mattwiebe
Copy link
Contributor

@pfefferle I assume we need to get these tests passed? I'd really like this merged into #593 before I bring in my error/logging stuff

@mattwiebe mattwiebe mentioned this pull request Jan 21, 2025
Merged
1 task
obenland added a commit that referenced this pull request Jan 21, 2025
@obenland
Use should_be_federated() instead
0919027 
See #1186.
@obenland obenland mentioned this pull request Jan 21, 2025
Merged
obenland
obenland reviewed Jan 21, 2025
View reviewed changes
includes/class-dispatcher.php Outdated Show resolved Hide resolved
includes/class-dispatcher.php Outdated Show resolved Hide resolved
includes/rest/class-outbox-controller.php Outdated Show resolved Hide resolved
obenland added a commit that referenced this pull request Jan 21, 2025
@obenland
Use should_be_federated() instead
3ff5565 
See #1186.
@mattwiebe
Copy link
Contributor

#1197 adds logging, and can form the basis of batching and retries as well

@pfefferle pfefferle added this to the Outbox milestone Jan 22, 2025
@pfefferle pfefferle requested a review from a team January 22, 2025 09:53
obenland
obenland reviewed Jan 22, 2025
View reviewed changes
includes/functions.php Show resolved Hide resolved
includes/transformer/class-base.php Outdated Show resolved Hide resolved
includes/scheduler/class-post.php Outdated Show resolved Hide resolved
obenland added a commit that referenced this pull request Jan 22, 2025
@obenland
Outbox: Use callbacks that can be unhooked. (#1188)
b0810d0 
* Outbox: Use callbacks that can be unhooked.

* Add unit tests

* Use data provider in no-activity tests

* Make sure user has activitypub cap

* Use should_be_federated() instead

See #1186.

* Update with learnings from #1196
pfefferle and others added 16 commits January 22, 2025 14:08
@pfefferle @obenland
rename dispatcher
00a5e2e
@pfefferle @obenland
Simple dispatcher based on the Outbox-Collection
f224701 
This is a simple rewrite of the current dispatcher system, to use the Outbox instead of the Scheduler.

This is a first draft and will be improved over time, to better handle:

* Re-tries
* Errors
* Logging
* Batch processing
@pfefferle @obenland
update changelog
318a2fd
@pfefferle @obenland
mark post as publish after federation id done
dcc68d3
@pfefferle @obenland
show only published activities
f04c682
@pfefferle @obenland
fix missing rename
3f4672b
@pfefferle @obenland
use pending instead of draft
5c6446d
@pfefferle @obenland
do not check for post_status
7f28a61
@pfefferle @obenland
fix tests
a1ce4e8 
props @obenland
@mattwiebe @obenland
Send Updates to Blog Actor in dual mode
98bbfa1
@pfefferle @obenland
Update includes/class-dispatcher.php
d83147b 
Co-authored-by: Konstantin Obenland <[email protected]>
@pfefferle @obenland
Update includes/class-dispatcher.php
bc9e6af 
Co-authored-by: Konstantin Obenland <[email protected]>
@pfefferle @obenland
Update includes/rest/class-outbox-controller.php
21d8e46 
Co-authored-by: Konstantin Obenland <[email protected]>
@pfefferle @obenland
Check if Activity should be sent to followers
06edf3b
@pfefferle @obenland
the unique check will be done send_activity_to_followers
7957a27
@pfefferle @obenland
fix tests
212c02f
@pfefferle pfefferle merged commit 9bcf121 into add/outbox-collection Jan 23, 2025
20 checks passed
@pfefferle pfefferle deleted the update/dispatcher branch January 23, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obenland obenland obenland approved these changes

@mattwiebe mattwiebe Awaiting requested review from mattwiebe

Assignees

@pfefferle pfefferle

Labels
[Feature] Collections
Projects
None yet
Milestone
Outbox
Development

Successfully merging this pull request may close these issues.
3 participants
@pfefferle @mattwiebe @obenland