Fix Dropdown menu border defect #8007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -1.83 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
dmvrtx
approved these changes
Jan 11, 2024
…orner-of-basic-filter-dropdowns-on-analytics-pages
mgascam
deleted the
fix/7991-blank-square-in-the-upper-left-corner-of-basic-filter-dropdowns-on-analytics-pages
branch
Jinksi
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7991
In a previous PR, we started to import the styles from
wordpress/componentsso the dropdown menu was correctly positioned. Unfortunately, this had a side effect: other instances of the dropdown menu started to display the following defect on the popover border:Changes proposed in this Pull Request
client/payment-details/summary/index.tsxclient/payment-details/summary/style.scss.Testing instructions
We need to test that the undesired side effects are fixed and, at the same time, the refunds dropdown menu is displayed correctly.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge