Removes 60 day survey #10464
Open
Removes 60 day survey #10464
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2025 18:33
- Stop adding the 60 day survey - Remove the survey note if already added.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Tested and confirmed that the note doesn't show anymore.
I did not remove the code as we need to reference the note inorder to delete it e.g.
WC_Payments_Notes_Qualitative_Feedback::possibly_delete_note();
Is there a reason the that the class WC_Payments_Notes_Qualitative_Feedback and any associated references cannot be removed also?
If there is a reason, when/how could they be deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10325
Changes proposed in this Pull Request
The 60 day survey note is added when the store meets the criteria. With these code changes
I did not remove the code as we need to reference the note inorder to delete it e.g.
WC_Payments_Notes_Qualitative_Feedback::possibly_delete_note();Testing instructions
developnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge