Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Ueno: add theme #6909

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Ueno: add theme #6909

merged 5 commits into from
Apr 20, 2023

Conversation

jffng
Copy link
Contributor

@jffng jffng commented Mar 13, 2023

Changes proposed in this Pull Request:

Adds new theme designed by @beafialho

Screenshot 2023-03-13 at 2 03 48 PM

To-do:

  • The default style’s typography is meant to be uppercase everywhere but the two variations are meant to be regular case. I defined it but after saving the variations, the text still showed up uppercase in all of them.
  • Duotone in images. Ueno Dark is supposed to use a duotone effect in all images, which also didn’t apply:

@jffng jffng requested a review from a team March 13, 2023 13:04
@vcanales vcanales self-assigned this Mar 17, 2023
@beafialho
Copy link
Collaborator

Sorry about the extra detail, but is it possible to set this color on links hover for the Dark Variation?

ueno links

@vcanales
Copy link
Contributor

@beafialho, getting back to your comments, they should be resolved on my end.

  • The default style’s typography is meant to be uppercase everywhere but the two variations are meant to be regular case. I defined it but after saving the variations, the text still showed up uppercase in all of them.
style-caps.mov
  • Duotone in images. Ueno Dark is supposed to use a duotone effect in all images, which also didn’t apply.

I found that it does apply, but it isn't immediately reflected in the editor when switching styles; you have to navigate away from it to see it there. It is applied in the front end correctly. I will file a Gutenberg bug with this issue, but it shouldn't keep the theme from being shipped.

UenoDuo.mp4

@beafialho
Copy link
Collaborator

Cool, thanks a lot!

@mikachan
Copy link
Member

I found that it does apply, but it isn't immediately reflected in the editor when switching styles; you have to navigate away from it to see it there.

I think this may be covered by this issue: WordPress/gutenberg#46397

Copy link
Contributor

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

@vcanales vcanales merged commit 28b059a into trunk Apr 20, 2023
@pbking pbking deleted the add/ueno branch May 9, 2023 16:48
@iamtakashi
Copy link
Contributor

This has been available in WP.org.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants