Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Email Preview Endpoint #31028

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Send Email Preview Endpoint #31028

merged 4 commits into from
Jun 1, 2023

Conversation

lezama
Copy link
Contributor

@lezama lezama commented May 29, 2023

Partially Fixes #31021

Proposed changes:

  • Introduces and endpoint that sends and email preview given a post id to the email of the current user.
  • Adds a Trait that could be reused on any endpoint that needs to proxy requests to wpcom.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

code-D110864
p2-peKye1-6z

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Run the new tests jetpack docker phpunit -- --filter=WP_Test_WPCOM_REST_API_V2_Endpoint_Send_Email_Preview
  • Apply bin/jetpack-downloader test jetpack add/preview-email-endpoint and D110864 to your wpcom sandbox.
  • Sandbox public-api
  • Use https://developer.wordpress.com/docs/api/console/ to test the new endpoint.
  • Use the client side Add Send Email Preview feature #31021 to test in your self-hosted site following the instructions in code-D110864
  • Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack add/preview-email-endpoint

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels May 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 29, 2023
@lezama lezama removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 30, 2023
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 30, 2023
@lezama lezama force-pushed the add/preview-email-endpoint branch from 530e4b8 to 5d84e4a Compare May 30, 2023 00:34
@lezama lezama mentioned this pull request May 30, 2023
3 tasks
@lezama lezama added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 30, 2023
@lezama lezama requested review from retrofox, jeherve, oskosk, creativecoder and a team May 30, 2023 09:47
@lezama lezama force-pushed the add/preview-email-endpoint branch from 3a57e43 to 7faf279 Compare June 1, 2023 12:15
@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Jun 1, 2023
@lezama lezama force-pushed the add/preview-email-endpoint branch 2 times, most recently from 4cb108b to 2f7c719 Compare June 1, 2023 17:00
kraftbj
kraftbj previously approved these changes Jun 1, 2023
kraftbj
kraftbj previously approved these changes Jun 1, 2023
@lezama lezama enabled auto-merge (squash) June 1, 2023 19:43
@lezama lezama force-pushed the add/preview-email-endpoint branch from 57a1a34 to daf75d3 Compare June 1, 2023 19:52
@lezama lezama merged commit 3614981 into trunk Jun 1, 2023
@lezama lezama deleted the add/preview-email-endpoint branch June 1, 2023 20:05
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jun 1, 2023
@github-actions github-actions bot added this to the jetpack/12.3 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Jetpack mu wpcom WordPress.com Features [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants