Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Preview: add to pre-publish sidebar #19992

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 1, 2021

Fixes #19915

Changes proposed in this Pull Request:

This PR adds the Jetpack Social Preview panel to the pre-publish sidebar.

Screen Shot 2021-06-01 at 12 32 19 pm

The Social Preview panel still appears in the Jetpack sidebar. (Or should we remove it from here?)

Screen Shot 2021-06-01 at 12 36 19 pm

Jetpack product discussion

p1HpG7-c4u-p2

Does this pull request change what data or activity we track or use?

Nah.

Testing instructions

  1. Run locally and create a new post.
  2. Check that the social preview appears (and the preview modal works) in the Jetpack menu, and in the pre-publish sidebar.
  3. Apply D62094-code to your sandbox, and check that the panel displays the upgrade nudge for a free, sandboxed site.
  4. Upgrade your test site to a Business plan. The Social Preview panel should show the preview modal.

Screen Shot 2021-06-01 at 12 54 23 pm

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello ramonjd! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D62094-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@ramonjd ramonjd self-assigned this Jun 1, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: July 6, 2021.
  • Scheduled code freeze: June 28, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 1, 2021
@ramonjd ramonjd requested review from marekhrabe and a team and removed request for marekhrabe June 1, 2021 02:56
Copy link
Member

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working nicely for me, a good simple addition! LGTM

image

The Social Preview panel still appears in the Jetpack sidebar. (Or should we remove it from here?)

Personally, I like that it appears in multiple places. After the post or page is published, I might want to go back in and check what the preview looks like before I share a link on Twitter. And if I already know it's a Jetpack feature, then being able to find it from the Jetpack plugin menu as well is nice.

✅ Tested that it works correctly in my local development environment
✅ In wpcom, on a free plan site, and a personal plan site, the social preview button opens up the modal with the upgrade nudge
✅ In wpcom on a business plan site, the social preview behaviour works correctly in the pre publish panel and within the Jetpack plugin menu

@andrewserong
Copy link
Member

Oh, and it looks like the failing CI jobs might be due to rate limiting? 🤞 they'll be resolved by re-running them at some stage?

@andrewserong andrewserong added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jun 1, 2021
@jeherve jeherve added this to the jetpack/9.9 milestone Jun 1, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jun 1, 2021
@kraftbj
Copy link
Contributor

kraftbj commented Jun 1, 2021

I'm okay with it being in both places, or at least removing it from the Jetpack panel later under a separate discussion.

@ramonjd ramonjd merged commit b312780 into master Jun 2, 2021
@ramonjd ramonjd deleted the add/social-preview-to-pre-publish-bar branch June 2, 2021 00:56
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Great news! One last step: head over to your WordPress.com diff, D62094-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 2, 2021
@ramonjd
Copy link
Member Author

ramonjd commented Jun 2, 2021

r226584-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Preview: Add to Pre- or Post-Publish Panel
6 participants