-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Preview: add to pre-publish sidebar #19992
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working nicely for me, a good simple addition! LGTM
The Social Preview panel still appears in the Jetpack sidebar. (Or should we remove it from here?)
Personally, I like that it appears in multiple places. After the post or page is published, I might want to go back in and check what the preview looks like before I share a link on Twitter. And if I already know it's a Jetpack feature, then being able to find it from the Jetpack plugin menu as well is nice.
✅ Tested that it works correctly in my local development environment
✅ In wpcom, on a free plan site, and a personal plan site, the social preview button opens up the modal with the upgrade nudge
✅ In wpcom on a business plan site, the social preview behaviour works correctly in the pre publish panel and within the Jetpack plugin menu
Oh, and it looks like the failing CI jobs might be due to rate limiting? 🤞 they'll be resolved by re-running them at some stage? |
I'm okay with it being in both places, or at least removing it from the Jetpack panel later under a separate discussion. |
…to-pre-publish-bar
…to-pre-publish-bar
Great news! One last step: head over to your WordPress.com diff, D62094-code, and commit it. Thank you! |
r226584-wpcom |
Fixes #19915
Changes proposed in this Pull Request:
This PR adds the Jetpack Social Preview panel to the pre-publish sidebar.
The Social Preview panel still appears in the Jetpack sidebar. (Or should we remove it from here?)
Jetpack product discussion
p1HpG7-c4u-p2
Does this pull request change what data or activity we track or use?
Nah.
Testing instructions
D62094-code
to your sandbox, and check that the panel displays the upgrade nudge for a free, sandboxed site.