Tier param setting call #1421
Open
Tier param setting call #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipapandinas
reviewed
Feb 13, 2025
| TypeInfo, | ||
| )] | ||
| #[scale_info(skip_type_params(NT))] | ||
| pub struct TierParametersV8<NT: Get<u32>> { |
There was a problem hiding this comment.
Suggestion - Move this type to the v8 module
There was a problem hiding this comment.
I've placed it here on purpose, to have everything related to v9 migration in one place.
That way we can already now remove the entire v8 migration sub module.
| impl<T: Config, InitArgs: Get<(u64, u64)>> UncheckedOnRuntimeUpgrade | ||
| for VersionMigrateV8ToV9<T, InitArgs> | ||
| { | ||
| fn on_runtime_upgrade() -> Weight { |
There was a problem hiding this comment.
Question: Is maintenance mode needed here?
There was a problem hiding this comment.
Not needed since we do the migration in a single block.
And this won't have immediate effect (unless it's the very same block at which tier reconfig should be done).
| @@ -411,15 +411,6 @@ impl DappStakingAccountCheck<AccountId> for AccountCheck { | |||
| } | |||
| } | |||
|
|
|||
| pub struct ShidenTierSlots; | |||
| impl TierSlotsFunc for ShidenTierSlots { | |||
Minimum allowed line rate is |
ipapandinas
approved these changes
Feb 13, 2025
|
I will merge this after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Adds
set_static_tier_paramsextrinsic to modify tier related dApp staking parameters dynamically.Requires
rootlevel privileges.Additionally expands the
TierParametersstruct to allow changing of the weight values of the linear equation used to determine number of slots.TODO
movePR)