Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback when API call fails. #36

Open
wants to merge 7 commits into
base: redesign
Choose a base branch
from

Conversation

benmuth
Copy link

@benmuth benmuth commented Jan 18, 2025

This PR adds a fallback in case the user is running an ArchiveBox version without a REST API (pre v0.8.0).

@pirate
Copy link
Member

pirate commented Jan 18, 2025

Excellent

Can you help record these three ~5-10sec screenrecording gifs, we'll use them for the new docs:

  1. setting up the server in the config UI + showing it turn green showing server is valid
  2. submitting a URL by clicking the menubar action button from a tab
  3. refreshing the server admin UI and showing the URL show up in the snapshot list

I like this app, but there are many others too that can make GIFs easily: https://gifox.app/

@benmuth
Copy link
Author

benmuth commented Jan 22, 2025

@pirate For people using 0.7.3, how should we handle auth? Should we add fields to the config UI to let them set the username and password, just like with the API key?

@pirate
Copy link
Member

pirate commented Jan 22, 2025

You should be able to just make a request to /add with the browser's existing cookies, you can see how the current codebase does it on the main branch.

The logic used to require that an API key was set in the extension
configuration even if version 0.7.3 was being used.
@benmuth benmuth marked this pull request as ready for review January 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants