Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functions called as object names #128

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Aug 2, 2024

Issue #124

Description

  • box_unused_att_pkg_fun_linter() now sees functions called as objects without ().

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@radbasa radbasa requested a review from jakubnowicki August 2, 2024 10:01
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (6254499) to head (bfe839a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   97.20%   97.21%           
=======================================
  Files          23       23           
  Lines        1111     1112    +1     
=======================================
+ Hits         1080     1081    +1     
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radbasa radbasa merged commit 17c7979 into main Aug 5, 2024
7 checks passed
@radbasa radbasa deleted the functions-called-as-object-names branch August 5, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants