Fix readonly snapshot invocation #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWittmann
previously approved these changes
Jun 3, 2024
EricWittmann
reviewed
Jun 3, 2024
| return location; | ||
| } | ||
| else { | ||
| log.debug("Skipping database snapshot because no location has been provided"); |
There was a problem hiding this comment.
Should this be a warning instead of debug??
carlesarnal
force-pushed
the
fix-readonly-snapshot-invocation
branch
from
1f73752 to
a8cf127
Compare
EricWittmann
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.