Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.4] skip EOS VM interpreter parallel unit_tests and spec_tests on sanitizer builds #965

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[1.0.4] skip EOS VM interpreter parallel unit_tests and spec_tests on sanitizer builds #965

merged 1 commit into from
Nov 7, 2024

Conversation

spoonincode
Copy link
Member

@spoonincode spoonincode commented Oct 21, 2024 •
edited by greg7mdp
Loading

EOS VM interpreter is slow. Sanitizer builds are slow. The two combined is really slow and we've fought CI test timeouts on and off with that combo.

EOS VM interpreter isn't useful for production usage so maybe just go ahead and disable the unit_test and wasm_spec_test runs with EOS VM interpreter for ASAN & UBSAN builds in CI.

Will resolve #958.

@spoonincode spoonincode added the CICD Anything dealing with the CI workflow behavior label Oct 21, 2024
@greg7mdp
Copy link
Contributor

Maybe it should go to the release/1.0 branch as well?

@heifner heifner mentioned this pull request Oct 22, 2024
Closed
@greg7mdp greg7mdp mentioned this pull request Oct 22, 2024
Merged
@heifner heifner linked an issue Oct 22, 2024 that may be closed by this pull request
Test failure: api_part2_unit_test_eos-vm #958
Closed
linh2931
linh2931 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing tests using EOS VM interpreter will also help remaining parallel unit tests run faster.

@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Optimize tests by skipping EOS VM interpreter unit tests on sanitizer builds.
Note:end

@spoonincode spoonincode changed the base branch from main to release/1.0 October 29, 2024 00:21
@spoonincode spoonincode changed the title [RFC] skip EOS VM interpreter parallel unit_tests and spec_tests on sanitizer builds [1.0.3] skip EOS VM interpreter parallel unit_tests and spec_tests on sanitizer builds Oct 29, 2024
@spoonincode spoonincode changed the title [1.0.3] skip EOS VM interpreter parallel unit_tests and spec_tests on sanitizer builds [1.0.4] skip EOS VM interpreter parallel unit_tests and spec_tests on sanitizer builds Oct 31, 2024
@bhazzard bhazzard mentioned this pull request Nov 7, 2024
Closed
@spoonincode spoonincode merged commit 4ebe18b into release/1.0 Nov 7, 2024
71 checks passed
@spoonincode spoonincode deleted the no_eos-vm_tests_asan_ubsan branch November 7, 2024 18:36
@bhazzard bhazzard linked an issue Nov 7, 2024 that may be closed by this pull request
Test failure: forked_tests_savanna_unit_test_eos-vm-oc #919
Closed
@bhazzard bhazzard removed a link to an issue Nov 7, 2024
Test failure: forked_tests_savanna_unit_test_eos-vm-oc #919
Closed
@spoonincode spoonincode mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
CICD Anything dealing with the CI workflow behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: api_part2_unit_test_eos-vm
5 participants
@spoonincode @greg7mdp @ericpassmore @heifner @linh2931